Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some examples marked as AS5600 use the AS5600L #57

Closed
Rob65 opened this issue Feb 21, 2024 · 6 comments · Fixed by #58
Closed

Some examples marked as AS5600 use the AS5600L #57

Rob65 opened this issue Feb 21, 2024 · 6 comments · Fixed by #58
Assignees
Labels
question Further information is requested wontfix This will not be worked on

Comments

@Rob65
Copy link

Rob65 commented Feb 21, 2024

While testing the AS5600 example, I could not get this to work.
Checking the I2C/Wire data with my scope showed that the slave address used was 0x40 - this is due to as5600 object being created from the AS5600L class instead of the AS5600.

I noticed this is also done in the following examples:
AS5600_angular_speed, AS5600_demo_ESP32, AS5600_demo_RP2040, AS5600_demo_status, AS5600_demo_STM32, AS5600_I2C_frequency and AS5600_resetCumulativeCounter examples.

@RobTillaart RobTillaart self-assigned this Feb 22, 2024
@RobTillaart RobTillaart added the question Further information is requested label Feb 22, 2024
@RobTillaart
Copy link
Owner

RobTillaart commented Feb 22, 2024

Well noticed,
The library implements the AS5600L as derived class too. During tests I used an L version at some moment and they were left in the code.. I could have duplicated every example but that would lead to double maintenance (and longer build CI times).

Will not fix this as it is easy adapted by the user.

@RobTillaart RobTillaart added the wontfix This will not be worked on label Feb 22, 2024
@Rob65
Copy link
Author

Rob65 commented Feb 23, 2024

Agree with not fixing but it might be nice to add a note on the main readme page to attent users to the fact that some examples use the 5600L. I tend to think I am fairly smart but it still to me a few minutes to notice this ;-)

@RobTillaart
Copy link
Owner

Fair enough,
I will add some notes today

RobTillaart added a commit that referenced this issue Feb 23, 2024
@RobTillaart
Copy link
Owner

Added comments on top of almost all examples:

//  Examples may use AS5600 or AS5600L devices.
//  Check if your sensor matches the one used in the example.
//  Optionally adjust the code.

@RobTillaart RobTillaart linked a pull request Feb 23, 2024 that will close this issue
@RobTillaart
Copy link
Owner

PR created
Build is running

RobTillaart added a commit that referenced this issue Feb 23, 2024
Fix #57, update comments in examples
@RobTillaart
Copy link
Owner

Build successful as expected as there were no code changes.
As the change is only comments I will not push a new version, it will become part of a next release.

Again, thanks for pointing out the issue,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants