-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast gestures on laggy sites are recognized improperly #636
Comments
As far as I know this cannot been solved. This is due to the (mostly) single threaded nature of JavaScript. Since the site is in use by other code or parsing HTML there is less room for dispatching any pointer events. Gesturefy is even using https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/getCoalescedEvents to get as much information about the mousemovement as possible.
If you perform a right swipe is it really always recognized as a left swipe? Can you make a screen recording of this (including your mouse cursor)? At least I cannot reproduce this and it also doesn't make sense to me. All I get is laggy gestures. Just to be clear, does the visual gesture representation somehow match the executed gesture for you (even though you might have moved your mouse differently then visualized)? |
notice how the gesture name appears only if there are any follow-up movements after the initial stroke - by then the buggy condition disappears and the gesture is properly recognized. also a tip for reproducing: you can increase a site lagginess to arbitrary levels by repeated duplicating of the main div node in developer tools. |
Gestures composed of two points were not visually matched (#636). This commit also removes the workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=1450692
Thanks for the recording and additional explanation.
So I think I was able to fix this. However I was not able to reproduce the following part:
Anyhow, can you please test the latest master branch? |
works perfectly, thanks! |
Describe your matter in detail
Performing a gesture very quickly on certain sites leads to a different gesture being fired. This usually happens when a heavy site is loading or sometimes even after the site is loaded (eg. https://devicehunt.com/all-usb-vendors ). No matter what gesture i perform, it's always recognized as a
leftdown drag. It only happens if the gesture is performed with a single quick stroke. It occurs even if you hold the mouse button down for a long time after the initial stroke, as long as the cursor doesn't move - if it moves even one pixel then the correct gesture will fire.Screenshots or further assistance
Your System
The text was updated successfully, but these errors were encountered: