Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open link in new tab doesn't work on https://archive.org/ #689

Closed
MJ1979 opened this issue Nov 5, 2023 · 4 comments
Closed

Open link in new tab doesn't work on https://archive.org/ #689

MJ1979 opened this issue Nov 5, 2023 · 4 comments
Labels

Comments

@MJ1979
Copy link

MJ1979 commented Nov 5, 2023

Perfect, absolutely perfect extension...
There is only one site (https://archive.org/), where open link in new tab doesn't work (when trying to open link of a book with gesture).

If you want to test here is a link for example
https://archive.org/search?query=Nikola+Tesla

Just as I was preparing the link above I've noticed that your other extension (Type to search) which I've installed today also doesn't recognize search box on that site so I had to disable it.

The issues are probably due to how that site was set-up and and not due to your extensions.

Thanks again for your great contribution... It saves me time every day...
All the best...

My System

  • Operating system: Windows 10
  • Firefox version: 119
  • Gesturefy version: 3.2.9
@MJ1979 MJ1979 changed the title Open links in new tab doesn't work on https://archive.org/ Open link in new tab doesn't work on https://archive.org/ Nov 5, 2023
Robbendebiene added a commit that referenced this issue Nov 5, 2023
@Robbendebiene
Copy link
Owner

Thanks for the report. I appreciate the nice words as well :)

I was able to fix the issue. The only fear I have is that I broke some "target detection" somewhere else (other commands or websites). Would be nice if you could test it as well.

You can try it as well by downloading https://github.com/Robbendebiene/Gesturefy/archive/refs/heads/master.zip
Extract the zip and then re-zip everything inside the src directory.

  • For a temporary installation (will be uninstalled on browser restart) go to about:debugging#/runtime/this-firefox, click "load temporary add-on" and choose the zip
  • For a permanent installation got to about:addons and install it by clicking the "gear" icon

Just as I was preparing the link above I've noticed that your other extension (Type to search) which I've installed today also doesn't recognize search box on that site so I had to disable it.

I actually don't maintain the "Type to search" extension any more. It never had a large user base and especially I stopped using it quite quickly my self so I lost interest and motivation.

@MJ1979
Copy link
Author

MJ1979 commented Nov 5, 2023

Thank you for the quick solution and response...

I've tried permanent installation but FF won't allow it. I get pop-up that it's not verified extension.
The xpinstall.signatures.required is set to false, but it seems that it does not do the trick anymore...

@MJ1979
Copy link
Author

MJ1979 commented Nov 5, 2023

Ok, so I've tried the temporary installation and it works perfectly!!!

Thank you so much.... can't wait for the official release....

Thank you again and all the best...

@Robbendebiene
Copy link
Owner

This is now fixed in Gesturefy version 3.2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants