Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the EnterFullscreen option #706

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

M4K14
Copy link
Contributor

@M4K14 M4K14 commented Feb 16, 2024

When you head to the Gesturefy settings>Extras and set these settings up:

wheel gesture = 'On'
wheel gesture mouse button = 'right'
wheel up = 'Toggle full screen'
wheel down = 'Toggle full screen'

Afterwards whenever you hold down the right click and scroll up, you repeatedly toggle the full screen up and down because you usually scroll the wheel rather than rolling it just as much as a single upward movement. Thus you usually get back to the screen size that you were already using and the window size is not properly toggled yet. that can be solved if we have a single "Full Screen" option which sets the window to full screen. then we can set the Gesturefy settings>Extras like this:

wheel gesture = 'On'
wheel gesture mouse button = 'right'
wheel up = 'full screen'
wheel down = 'Maximize window'

now you'll never face that problem ever again.

190888658-28adada4-5c13-4e88-99ef-bb129d77f2b7

190888656-71c24006-c050-4892-b93d-478bdcd3fa5a

@M4K14 M4K14 changed the title Added the EnterFulscreen option Added the EnterFullscreen option Feb 16, 2024
Copy link
Owner

@Robbendebiene Robbendebiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Looks good, just some minor formatting 🙂

src/core/commands.mjs Outdated Show resolved Hide resolved
@Robbendebiene Robbendebiene merged commit 85bddc5 into Robbendebiene:master Apr 2, 2024
@M4K14
Copy link
Contributor Author

M4K14 commented Apr 4, 2024

Thanks for the review and sorry for the late fixes as well :)
It's an honor to contribute to one of my most used add-ons.
Can't wait to have this feature on the native add-on when it's updated on the store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants