Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing originalError with cause on validation errors #2137

Merged
merged 6 commits into from
Nov 2, 2024
Merged

Replacing originalError with cause on validation errors #2137

merged 6 commits into from
Nov 2, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Nov 2, 2024 •
edited
Loading

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Nov 2, 2024
RobinTail
RobinTail commented Nov 2, 2024
View reviewed changes
tests/unit/errors.spec.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail marked this pull request as ready for review November 2, 2024 08:33
@RobinTail RobinTail added the documentation Improvements or additions to documentation label Nov 2, 2024
RobinTail
RobinTail commented Nov 2, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail mentioned this pull request Nov 2, 2024
Closed
@RobinTail RobinTail merged commit 618e54f into master Nov 2, 2024
11 checks passed
@RobinTail RobinTail deleted the mv-originalError-cause branch November 2, 2024 09:01
@RobinTail RobinTail mentioned this pull request Nov 2, 2024
Merged
RobinTail added a commit that referenced this pull request Nov 2, 2024
@RobinTail
Drop originalError property on validation errors (#2139)
50165f9 
Due to #2137 deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail