Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing .flatMap() with chain() #2209

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Replacing .flatMap() with chain() #2209

merged 7 commits into from
Nov 26, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Nov 25, 2024 •
edited
Loading

Confirmed to be faster in #2208

with added eslint rule

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Nov 25, 2024
RobinTail
RobinTail commented Nov 25, 2024
View reviewed changes
src/common-helpers.ts Outdated Show resolved Hide resolved
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Nov 25, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling b5544c4 on ref-flatmap-chain
into 3425848 on master.

RobinTail
RobinTail commented Nov 26, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Nov 26, 2024
View reviewed changes
src/zts.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail marked this pull request as ready for review November 26, 2024 13:32
RobinTail
RobinTail commented Nov 26, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit 5b86956 into master Nov 26, 2024
11 checks passed
@RobinTail RobinTail deleted the ref-flatmap-chain branch November 26, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail