Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating EncodedResponse interface by Integration #2226

Merged
merged 60 commits into from
Dec 14, 2024
Merged

Generating EncodedResponse interface by Integration #2226

merged 60 commits into from
Dec 14, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Dec 1, 2024 •
edited
Loading

Should go after #2225

Based on discussion #2219

@RobinTail RobinTail added the enhancement New feature or request label Dec 1, 2024
@RobinTail RobinTail added this to the v22 milestone Dec 1, 2024
@RobinTail RobinTail changed the title Splitting positive response further to the status codes. Splitting response further to the status codes Dec 1, 2024
@RobinTail RobinTail mentioned this pull request Dec 1, 2024
Merged
@RobinTail
Copy link
Owner Author

I'm not sure it would allow making status code operating client.
It would require a single 3-dimensional dictionary-like interface.

@RobinTail RobinTail changed the title Splitting response further to the status codes Exp: Splitting response further to the status codes Dec 2, 2024
RobinTail added a commit that referenced this pull request Dec 2, 2024
@RobinTail
Always split response type (#2225)
d8b105e 
Partially based on discussion
#2219
Needed for #2226 
But generally should simplify the flow and enable further improvements
of the Integration class
Base automatically changed from always-split-response to master December 2, 2024 11:21
@RobinTail RobinTail mentioned this pull request Dec 2, 2024
Draft
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Dec 2, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling e4a8d28 on emphasise-status-code
into 2806088 on master.

@RobinTail RobinTail changed the title Exp: Integration producing EncodedResponse interface Generating EncodedResponse interface by Integration Dec 8, 2024
@RobinTail RobinTail added the refactoring The better way to achieve the same result label Dec 8, 2024
RobinTail
RobinTail commented Dec 11, 2024
View reviewed changes
example/example.client.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail marked this pull request as ready for review December 11, 2024 21:20
@RobinTail RobinTail mentioned this pull request Dec 11, 2024
Merged
RobinTail added a commit that referenced this pull request Dec 11, 2024
@RobinTail
Fix: no duplicates in Path type generated by Integration (#2251)
098bcb8 
Found this one during my work on #2226
RobinTail
RobinTail commented Dec 12, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK in general

RobinTail
RobinTail commented Dec 12, 2024
View reviewed changes
example/example.client.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Dec 14, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ QA passed

@RobinTail RobinTail merged commit d279c4f into master Dec 14, 2024
12 checks passed
@RobinTail RobinTail deleted the emphasise-status-code branch December 14, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail