Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating jsonEndpoints public const #2258

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Deprecating jsonEndpoints public const #2258

merged 2 commits into from
Dec 20, 2024

Conversation

RobinTail
Copy link
Owner

This is redundant and should be removed in v22.
The actual content-type header of the response should be used instead.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Dec 20, 2024
@RobinTail RobinTail marked this pull request as ready for review December 20, 2024 16:34
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Dec 20, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling dbca6c0 on deprecate-jsonEndpoints
into 1f230d0 on master.

@RobinTail RobinTail force-pushed the deprecate-jsonEndpoints branch from 12668e9 to dbca6c0 Compare December 20, 2024 16:40
RobinTail
RobinTail commented Dec 20, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit 9575db7 into master Dec 20, 2024
11 checks passed
@RobinTail RobinTail deleted the deprecate-jsonEndpoints branch December 20, 2024 16:44
@RobinTail RobinTail mentioned this pull request Dec 20, 2024
Merged
RobinTail added a commit that referenced this pull request Dec 20, 2024
@RobinTail
Drop jsonEndpoints (#2259)
dc0494d 
Deprecated in #2258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail