Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(Integration): delegating props quotation to specific cases #2274

Merged
merged 5 commits into from
Dec 31, 2024
Merged

ref(Integration): delegating props quotation to specific cases #2274

merged 5 commits into from
Dec 31, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Dec 31, 2024 •
edited
Loading

instead of quoteProp() helper there should be proper handling of particular cases

Should be helpful for #2269

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Dec 31, 2024
RobinTail
RobinTail commented Dec 31, 2024
View reviewed changes
src/integration.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Dec 31, 2024
View reviewed changes
src/integration.ts Outdated Show resolved Hide resolved
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Dec 31, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling cc70156 on no-quoteProp
into 20c5735 on master.

@RobinTail RobinTail marked this pull request as ready for review December 31, 2024 14:19
@RobinTail RobinTail changed the title Ref: moving prop quotation for Integration ref(Integration): delegating props quotation to specific cases Dec 31, 2024
RobinTail
RobinTail commented Dec 31, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@RobinTail RobinTail merged commit 2863dda into master Dec 31, 2024
11 checks passed
@RobinTail RobinTail deleted the no-quoteProp branch December 31, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail