Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable client class name #2336

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Jan 23, 2025

I still wanna make the breaking change in v22 that changes the class name to just Client, but there will be a feature to configure it for consumer's needs

@RobinTail RobinTail added the enhancement New feature or request label Jan 23, 2025
Copy link

coveralls-official bot commented Jan 23, 2025

Coverage Status

coverage: 100.0%. remained the same
when pulling 04aab93 on configurable-client-class-name
into fb25b7e on master.

Base automatically changed from make-v22 to master January 24, 2025 08:39
@RobinTail RobinTail changed the title feat(v22): Configurable client class name feat: Configurable client class name Jan 24, 2025
@RobinTail RobinTail marked this pull request as ready for review January 25, 2025 07:01
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit 023e55c into master Jan 25, 2025
9 checks passed
@RobinTail RobinTail deleted the configurable-client-class-name branch January 25, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant