Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python from 3.10.5-bullseye to 3.11.0-bullseye #48

Merged
merged 17 commits into from
Dec 5, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2022

Bumps python from 3.10.5-bullseye to 3.11.0-bullseye.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Oct 25, 2022
@dependabot dependabot bot force-pushed the dependabot/docker/python-3.11.0-bullseye branch 2 times, most recently from cf38a6d to e9c9f3d Compare November 21, 2022 18:49
@JeffreyBlinksma
Copy link
Collaborator

Checks failing, does pyodbc need to be updated?

@dependabot dependabot bot force-pushed the dependabot/docker/python-3.11.0-bullseye branch 3 times, most recently from c52db37 to 80f059f Compare November 21, 2022 19:06
Bumps python from 3.10.5-bullseye to 3.11.0-bullseye.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/docker/python-3.11.0-bullseye branch from 80f059f to a8e17ca Compare November 30, 2022 17:48
ThatOneNovaGuy and others added 15 commits December 5, 2022 10:40
Testing if pyodbc update to 4.0.35 passes checks.
We are checking.
pyodbc==4.0.35 was being built, but it was trying to install pyodbc==4.0.32, which doesn't exist because it wasn't built.
The build container was updated to Python 3.11.0, but not the app container that runs the code, which was still on 3.10.4.
Dockerfile Outdated
Comment on lines 7 to 8
python -m pip wheel --no-binary :all: --wheel-dir /tmp/wheelhouse pyodbc==4.0.35 &&\
python -m pip wheel --no-binary :all: --wheel-dir /tmp/wheelhouse cffi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to merge these two lines?

Dockerfile Outdated
Comment on lines 7 to 8
python -m pip wheel --no-binary :all: --wheel-dir /tmp/wheelhouse pyodbc==4.0.35 &&\
python -m pip wheel --no-binary :all: --wheel-dir /tmp/wheelhouse cffi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See issue #53

ThatOneNovaGuy
ThatOneNovaGuy previously approved these changes Dec 5, 2022
Copy link
Collaborator

@ThatOneNovaGuy ThatOneNovaGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT WORKS

@@ -24,7 +23,7 @@ RUN \

#Copy pyodbc and cffi wheels to app container, and install them
COPY --from=builder /tmp/wheelhouse /tmp/wheelhouse
RUN ls /tmp/wheelhouse && pip install --find-links=/tmp/wheelhouse pyodbc==4.0.32 cffi
RUN ls /tmp/wheelhouse && pip install --no-cache-dir --no-index --find-links=/tmp/wheelhouse pyodbc==4.0.35 cffi

#install other redependencies and copy application
RUN pip install cryptography==36.0.2 zeep==4.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies are currently not linked to requirements.txt. We should link them in the coming time.

@ThatOneNovaGuy
Copy link
Collaborator

@dependabot merge

@dependabot dependabot bot merged commit 57331c2 into master Dec 5, 2022
@dependabot dependabot bot deleted the dependabot/docker/python-3.11.0-bullseye branch December 5, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants