Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize Cardboard and push latest version #63

Merged
merged 20 commits into from
Jan 28, 2023
Merged

Modularize Cardboard and push latest version #63

merged 20 commits into from
Jan 28, 2023

Conversation

JeffreyBlinksma
Copy link
Collaborator

No description provided.

@JeffreyBlinksma
Copy link
Collaborator Author

Has yet to be tested.

@JeffreyBlinksma JeffreyBlinksma linked an issue Dec 22, 2022 that may be closed by this pull request
Dependencies not linked to requirements.txt #54
Closed
@JeffreyBlinksma JeffreyBlinksma marked this pull request as draft December 22, 2022 23:00
@ThatOneNovaGuy
Update Dockerfile
c043c7d 
Update Dockerfile to CodeFactor standards (probably)
@ThatOneNovaGuy
Update Dockerfile
6b08d7a 
Added variation of fix, using `WORKDIR /` command to reset directory.
@JeffreyBlinksma
Copy link
Collaborator Author

JeffreyBlinksma commented Dec 24, 2022 •
edited
Loading

Errors out with

  File "/app/main.py", line 3, in <module>
    import pyodbc
ModuleNotFoundError: No module named 'pyodbc'

@JeffreyBlinksma
Copy link
Collaborator Author

Downgrading to Python 3.10.9 has temporarily fixed this, allowing us to merge this pull request. This should be fixed in a future PR.

@JeffreyBlinksma JeffreyBlinksma marked this pull request as ready for review January 28, 2023 13:06
JeffreyBlinksma and others added 2 commits January 28, 2023 15:51
@JeffreyBlinksma
Fix receipt generation
f7181a7 
This should really be moved into a function...
@ThatOneNovaGuy
Merge branch 'master' into modularization
bc7d130
ThatOneNovaGuy
ThatOneNovaGuy approved these changes Jan 28, 2023
View reviewed changes
Copy link
Collaborator

@ThatOneNovaGuy ThatOneNovaGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sepay.py could use improvement, but this can be done in a later PR. The primary objective of this one is updating the repository to the live dev build.

@ThatOneNovaGuy ThatOneNovaGuy merged commit 24cdf07 into master Jan 28, 2023
@ThatOneNovaGuy ThatOneNovaGuy deleted the modularization branch January 28, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThatOneNovaGuy ThatOneNovaGuy ThatOneNovaGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies not linked to requirements.txt
2 participants
@JeffreyBlinksma @ThatOneNovaGuy