This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Introduce much more detailed setState error messages #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/invalidSetStateMessages.lua
Outdated
| Check the component %q to see if: | ||
| * setState could be called by a child Ref | ||
| * setState could be called by a child Changed event | ||
| * setState could be called by a child's render method]] |
There was a problem hiding this comment.
Nitpick, but might be clearer to say "setState is being called by...". Otherwise, it kind of sounds like a suggestion rather than a possible diagnosis.
There was a problem hiding this comment.
I'll probably also fold that part into the section before the list, like:
Check the component %q to see if setState is being called by:
- a child Ref
- a child Changed event
- a child's render method
| Check the definition of shouldUpdate in the component %q.]] | ||
|
|
||
| invalidSetStateMessages["init"] = [[ | ||
| setState cannot be used in the init method. |
There was a problem hiding this comment.
It might be helpful to mention that you can set state directly in init.
|
All of the messages are updated. Any other feedback? |
|
Nah, LGTM! |
|
LGTM as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66.
This PR replaces the single "you can't use setState here" message with a bunch of new messages, each tailored to the exact case.
They give much more useful information, and where possible, where to put your
setStatecall instead.It also catches an extra case where the render and reconciliation steps were not being guarded, specifically during reify.