Packaging fix ubuntu #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2018 17:42
HUGE is not defined in math.h anymore in Ubuntu/bionic. This is most likely due to a newer version of glibc.
Package creation was broken because dpkg-shlibdeps could not find liblcm.so inside the created package. This is because the package is installing the tools and the libraries in a non-standard location. As a work around, we set R(UN)PATH to be able to find liblcm.so at packaging time. RPATH or RUNPATH are set depending on the default configuration of the compiler/linker on the current platform. CMake 3.6 is required to use $ORIGIN in R(UN)PATH for CPackDeb.cmake module to work.
jamiesnape
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.