fix new/delete mismatch

Memory allocated with new must be freed with delete, not free.
RobotWebTools · Jul 17, 2018 · 7549cfe · 7549cfe
1 parent 7f6de3f
commit 7549cfe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/executor.cpp b/src/executor.cpp
@@ -62,7 +62,7 @@ void Executor::Stop() {
                  // Important Notice:
                  //  This might be called after Executor::~Executor()
                  //  Don't free Executor::async_ in Executor's dtor
-                 free(async);
+                 delete async;
                  handle_closed = true;
                });
       while (!handle_closed)

diff --git a/src/rcl_bindings.cpp b/src/rcl_bindings.cpp
@@ -669,8 +669,7 @@ const rmw_qos_profile_t* GetQosProfileFromObject(v8::Local<v8::Object> object) {
 }
 
 rmw_qos_profile_t* GetQoSProfile(v8::Local<v8::Value> qos) {
-  rmw_qos_profile_t* qos_profile =
-      reinterpret_cast<rmw_qos_profile_t*>(malloc(sizeof(rmw_qos_profile_t)));
+  rmw_qos_profile_t* qos_profile = new rmw_qos_profile_t();
 
   if (qos->IsString()) {
     *qos_profile = *GetQoSProfileFromString(