Skip to content

Commit

Permalink
Update eventemitter from v2 to v3 (#681)
Browse files Browse the repository at this point in the history
* fixed by npm audit fix

* change to  "eventemitter3": "^5.0.1"

* Adjust es6 transpiler to eventemitter3

* Fix tests to work with eventemitter3

---------

Co-authored-by: Matthijs van der Burgh <matthijs.van.der.burgh@vbti.nl>
  • Loading branch information
ipa-rwu and MatthijsBurgh authored Oct 18, 2024
1 parent b3a9ebc commit 237b5e8
Show file tree
Hide file tree
Showing 11 changed files with 266 additions and 424 deletions.
2 changes: 1 addition & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"mocha": true
},
"globals": {
"EventEmitter2": true,
"EventEmitter3": true,
"THREE": true,
"ROS3D": true,
"ROSLIB": true,
Expand Down
4 changes: 2 additions & 2 deletions es6-transpiler.js
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,8 @@ const transpile = {
importString = "import * as ROSLIB from 'roslib';"
break;
}
case 'EventEmitter2': {
importString = "import EventEmitter2 from 'eventemitter2';"
case 'EventEmitter3': {
importString = "import EventEmitter3 from 'eventemitter3';"
break;
}
case 'ColladaLoader': {
Expand Down
Loading

0 comments on commit 237b5e8

Please sign in to comment.