Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update occupancy grid rendering #339

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Conversation

J-Rojas
Copy link
Contributor

@J-Rojas J-Rojas commented Sep 16, 2020

Use raw probabilities values from the occupancy grid as part of the color scale instead of encoding them as only 3 discrete values:

0 will be rendered as black, 100 as full color.

Do not use linear filtering, instead use nearest filter so the texture appears as a grid.

Here's what the rendering looks like:

Rendering

Update OccupancyGridClient to only add the scene node once instead of adding multiple scene nodes if there are multiple ROS updates.

…olor scale instead of encoding them as only 3 discrete values:

0 will be rendered as black, 100 as full color.

Do not use linear filtering, instead use nearest filter so the texture appears as a grid.
@J-Rojas J-Rojas requested a review from jihoonl September 16, 2020 22:15
@J-Rojas J-Rojas requested a review from mvollrath September 18, 2020 17:32
Copy link
Contributor

@mvollrath mvollrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big visual change (improvement), well done.

@mvollrath mvollrath merged commit a62a3a3 into develop Sep 18, 2020
@J-Rojas
Copy link
Contributor Author

J-Rojas commented Sep 18, 2020

No problem, was surprised it wasn't modified earlier. It's the first time I've used this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants