Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rollup plugins #390

Merged
merged 3 commits into from
May 14, 2021
Merged

Update rollup plugins #390

merged 3 commits into from
May 14, 2021

Conversation

MatthijsBurgh
Copy link
Contributor

@MatthijsBurgh MatthijsBurgh commented May 10, 2021 •
edited
Loading

Uglify was not really minifying.

Also the uglify plugin was not compatible with rollup2

Closes #385

Also migrate to plugins in rollup namespace as others are not maintained anymore.

@MatthijsBurgh MatthijsBurgh requested a review from a team May 10, 2021 11:34
@MatthijsBurgh MatthijsBurgh changed the title use Terser plugin instead of Uglify Update plugins May 10, 2021
@MatthijsBurgh MatthijsBurgh changed the title Update plugins Update rollup plugins May 12, 2021
@MatthijsBurgh MatthijsBurgh merged commit 189bb5b into develop May 14, 2021
@MatthijsBurgh MatthijsBurgh deleted the terser branch May 14, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoonl jihoonl jihoonl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthijsBurgh @jihoonl