Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket.js: ReferenceError: global is not defined #302

Closed
JulianAssmann opened this issue Oct 26, 2018 · 2 comments
Closed

Websocket.js: ReferenceError: global is not defined #302

JulianAssmann opened this issue Oct 26, 2018 · 2 comments

Comments

@JulianAssmann
Copy link

JulianAssmann commented Oct 26, 2018

When I try to use roslibjs in angular and the @types/roslib package, i get the following error:

ReferenceError: global is not defined
./node_modules/roslib/src/util/shim/WebSocket.js - WebSocket.js:1
__webpack_require__ - bootstrap:78
./node_modules/roslib/src/core/Ros.js - Ros.js:6:16
__webpack_require__ - bootstrap:78
./node_modules/roslib/src/core/index.js - index.js:4:9
__webpack_require__ - bootstrap:78
./node_modules/roslib/src/RosLib.js - RosLib.js:18:15
__webpack_require__ - bootstrap:78
./src/app/shared/ros.service.ts - http://localhost:4200/main.js:263:64
__webpack_require__ - bootstrap:78
./src/app/connection/connection.component.ts - http://localhost:4200/main.js:216:77
__webpack_require__ - bootstrap:78
./src/app/app.module.ts - http://localhost:4200/main.js:158:90
__webpack_require__ - bootstrap:78
./src/main.ts - main.ts:1
__webpack_require__ - bootstrap:78
0 - http://localhost:4200/main.js:378:18
__webpack_require__ - bootstrap:78
checkDeferredModules - bootstrap:45
webpackJsonpCallback - bootstrap:32
<anonymous> - http://localhost:4200/main.js:1:2
@JulianAssmann
Copy link
Author

I saw #286 will solve this problem. It only needs to be merged.

@viktorku
Copy link
Member

viktorku commented Nov 6, 2018

The PR has been merged. I'm gonna go ahead and close this.

@viktorku viktorku closed this as completed Nov 6, 2018
k-aguete pushed a commit to k-aguete/roslibjs that referenced this issue Oct 21, 2022
* remove from markers array and dispose children

* refactor repeated code into method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants