Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.0 #314

Merged
merged 1 commit into from
Jan 25, 2019
Merged

1.0.0 #314

merged 1 commit into from
Jan 25, 2019

Conversation

mvollrath
Copy link
Contributor

Fixes #311

This was referenced Jan 16, 2019
Closed
Merged
Open
@jihoonl
Copy link
Member

jihoonl commented Jan 17, 2019

@mvollrath what's your npm id? I will add you to npm org so can release the library in npm

@jihoonl jihoonl requested a review from viktorku January 17, 2019 06:39
@jihoonl
Copy link
Member

jihoonl commented Jan 17, 2019

@viktorku Would you take a look? and what's your npm id as well?

@mvollrath
Copy link
Contributor Author

https://www.npmjs.com/~mdevolving

@mvollrath mvollrath mentioned this pull request Jan 22, 2019
Open
@jihoonl jihoonl merged commit 8954884 into RobotWebTools:develop Jan 25, 2019
@mvollrath
Copy link
Contributor Author

I should now update the builds and push a tag?

@jihoonl
Copy link
Member

jihoonl commented Jan 25, 2019

yup. That would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoonl jihoonl jihoonl approved these changes

@viktorku viktorku Awaiting requested review from viktorku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvollrath @jihoonl