Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] convert to ES Module format #475

Closed
wants to merge 32 commits into from
Closed

[WIP] convert to ES Module format #475

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e46aa82
initial conversion of files to ES Module format
trusktr Sep 12, 2021
2dc1db6
finish initial ESM format in source files, built ESM, CJS, and UMD ou…
trusktr Sep 14, 2021
8e71261
Merge branch 'develop' into convert-to-esm
trusktr Sep 14, 2021
20385ad
remove comment to hopefully trigger build
trusktr Sep 14, 2021
a6ca753
make sure to call grunt with Gruntfile.cjs
trusktr Sep 15, 2021
17d73e5
switch to eslint, get lint and build passing (output not yet tested)
trusktr Sep 16, 2021
31224af
get mocha tests passing
trusktr Sep 17, 2021
dcc10f5
set karma back to single run for CI
trusktr Sep 17, 2021
aee7a57
get base karma tests passing (the ones ran by `npm test`)
trusktr Sep 17, 2021
1a7b720
remove comments from Gruntfile
trusktr Sep 17, 2021
fbd53bc
Merge branch 'develop' into convert-to-esm
trusktr Sep 17, 2021
7db2591
run `npm test` before other tests
trusktr Sep 17, 2021
180e1e7
install before testing
trusktr Sep 21, 2021
675ca49
delete package-lock.json to fix the fsevents error on CI. Plus packag…
trusktr Sep 21, 2021
d3799a5
initial conversion of test/examples to ESM
trusktr Sep 21, 2021
54c6316
add @babel/core that CI says was missing
trusktr Sep 27, 2021
ada3edf
Merge branch 'develop' into convert-to-esm
trusktr Sep 27, 2021
17f9e7c
update npm version in CI
trusktr Sep 27, 2021
793c940
delete package-lock.json again (restored on accident from last merge)
trusktr Sep 27, 2021
bdc7f68
install dependencies with --legacy-peer-deps, for now
trusktr Sep 27, 2021
30fd409
update workersocket test code to ESM
trusktr Sep 27, 2021
98edbfe
update eslint to 8.0.0-rc.0
trusktr Sep 27, 2021
42d6590
use nvm in Dockerfile to set the latest npm version
trusktr Sep 27, 2021
bd5ed0c
install chromium-browser for CI
trusktr Sep 27, 2021
42b3004
build before testing
trusktr Sep 27, 2021
1d428a1
the --no-sandbox flag for Chrome is needed when running in CI
trusktr Sep 27, 2021
f3c43db
add comment about DOckerfile CHROME_BIN env var
trusktr Sep 27, 2021
c8dda47
run non-ROS tests before doing anything with ROS
trusktr Sep 27, 2021
ee2d985
make the repo friendly to npm install
trusktr Sep 28, 2021
893751a
add a tet that ensures the code follows Node ESM spec
trusktr Sep 28, 2021
2ce4ddc
ignore build output, libraries don't need lock files
trusktr Oct 3, 2021
278f847
simpify .npmignore
trusktr Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions Gruntfile.js → Gruntfile.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,15 @@ module.exports = function(grunt) {

grunt.initConfig({
pkg: grunt.file.readJSON('package.json'),
browserify: {
dist: {
src: ['./src/RosLibBrowser.js'],
dest: './build/roslib.js'
// browserify: {
// dist: {
// src: ['./src/RosLibBrowser.js'],
// dest: './build/roslib.js'
// }
// },
shell: {
build: {
command: 'rollup -c'
}
},
jshint: {
Expand Down Expand Up @@ -110,7 +115,8 @@ module.exports = function(grunt) {
grunt.registerTask('test-examples', ['mochaTest:examples', 'karma:examples']);
grunt.registerTask('test-tcp', ['mochaTest:tcp']);
grunt.registerTask('test-workersocket', ['karma:workersocket']);
grunt.registerTask('build', ['browserify', 'uglify']);
// grunt.registerTask('build', ['browserify', 'uglify']);
grunt.registerTask('build', ['shell']);
grunt.registerTask('build_and_watch', ['watch']);
grunt.registerTask('doc', ['clean', 'jsdoc']);
};
Loading