Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webworkify-webpack with webpack #513

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Use webworkify-webpack with webpack #513

merged 1 commit into from
Feb 8, 2022

Conversation

MatthijsBurgh
Copy link
Contributor

@MatthijsBurgh MatthijsBurgh commented Jan 22, 2022 •
edited
Loading

Fixes #382

@MatthijsBurgh MatthijsBurgh mentioned this pull request Jan 22, 2022
Closed
@MatthijsBurgh MatthijsBurgh requested a review from a team January 23, 2022 15:34
@MatthijsBurgh MatthijsBurgh marked this pull request as ready for review January 23, 2022 15:34
@MatthijsBurgh
Copy link
Contributor Author

@jihoonl @mvollrath @J-Rojas any comments?

@MatthijsBurgh MatthijsBurgh merged commit c87a8ad into develop Feb 8, 2022
@MatthijsBurgh MatthijsBurgh deleted the webworkify branch February 8, 2022 12:37
@HiggsWRX
Copy link

HiggsWRX commented Mar 26, 2022 •
edited
Loading

I absolutely love this PR. You saved my bacon with this PR, and so many hours of headache. Bless you

@PhilippeMorier
Copy link

Hi @MatthijsBurgh 👋!

  • Do you already know when this fix will be released?
  • What can I do in the meanwhile?

Thanks a lot!

@MatthijsBurgh
Copy link
Contributor Author

It has been released.

@PhilippeMorier
Copy link

Amazing 🎉!

Thanks a lot 🙏!

k-aguete pushed a commit to k-aguete/roslibjs that referenced this pull request Oct 21, 2022
@dependabot
Bump rollup from 2.68.0 to 2.70.0 (RobotWebTools#513)
6d869e4 
Bumps [rollup](https://github.com/rollup/rollup) from 2.68.0 to 2.70.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.68.0...v2.70.0)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with roslibjs and Webpack 5
3 participants
@MatthijsBurgh @HiggsWRX @PhilippeMorier