Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement delete objects #38

Merged
merged 3 commits into from
Jan 1, 2023
Merged

implement delete objects #38

merged 3 commits into from
Jan 1, 2023

Conversation

Robothy
Copy link
Owner

@Robothy Robothy commented Jan 1, 2023

No description provided.

Route DeleteObjects = Route.builder()
.method(HttpMethod.POST)
.path("/{bucket}")
.paramMatcher(params -> params.containsKey("delete"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollectionUndefinedEquality: CharSequence does not have well-defined equals behavior.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Route DeleteObjects_ = Route.builder()
.method(HttpMethod.POST)
.path("/{bucket}/")
.paramMatcher(params -> params.containsKey("delete"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollectionUndefinedEquality: CharSequence does not have well-defined equals behavior.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Merging #38 (4724d07) into master (1f7377c) will increase coverage by 0.40%.
The diff coverage is 95.78%.

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
+ Coverage     84.45%   84.86%   +0.40%     
- Complexity      684      705      +21     
============================================
  Files           165      170       +5     
  Lines          2567     2662      +95     
  Branches        133      139       +6     
============================================
+ Hits           2168     2259      +91     
- Misses          322      323       +1     
- Partials         77       80       +3     
Impacted Files Coverage Δ
.../robothy/s3/core/service/DeleteObjectsService.java 92.30% <92.30%> (ø)
...om/robothy/s3/datatypes/response/DeleteResult.java 92.59% <92.59%> (ø)
...ava/com/robothy/s3/datatypes/ObjectIdentifier.java 100.00% <100.00%> (ø)
...thy/s3/datatypes/request/DeleteObjectsRequest.java 100.00% <100.00%> (ø)
...ava/com/robothy/s3/datatypes/response/S3Error.java 92.30% <100.00%> (+1.39%) ⬆️
...bothy/s3/rest/handler/DeleteObjectsController.java 100.00% <100.00%> (ø)
.../robothy/s3/rest/handler/LocalS3RouterFactory.java 99.45% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Robothy Robothy merged commit 7c31be2 into master Jan 1, 2023
@Robothy Robothy deleted the ISSUE-37 branch January 1, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant