-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support user-defined object metadata #59
Conversation
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=========================================
Coverage 85.15% 85.15%
- Complexity 737 747 +10
=========================================
Files 173 173
Lines 2742 2776 +34
Branches 155 157 +2
=========================================
+ Hits 2335 2364 +29
- Misses 326 329 +3
- Partials 81 83 +2
|
@@ -26,4 +27,6 @@ public class GetObjectAns { | |||
|
|||
private InputStream content; | |||
|
|||
private Map<String, String> userMetadata; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.
private Map<String, String> userMetadata; | |
SuppressWarnings |
❗❗ 2 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
File Path | Line Number |
---|---|
local-s3-core/src/main/java/com/robothy/s3/core/model/request/PutObjectOptions.java | 24 |
local-s3-core/src/main/java/com/robothy/s3/core/model/internal/VersionedObjectMetadata.java | 34 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/Robothy/local-s3/59.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/Robothy/local-s3/59.diff | git apply Once you're satisfied, commit and push your changes in your project. Footnotes |
https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingMetadata.html#UserMetadata