Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support user-defined object metadata #59

Merged
merged 1 commit into from
Jun 19, 2023
Merged

support user-defined object metadata #59

merged 1 commit into from
Jun 19, 2023

Conversation

Robothy
Copy link
Owner

@Robothy Robothy commented Jun 16, 2023

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #59 (6f075b8) into master (0842f5f) will increase coverage by 0.00%.
The diff coverage is 85.29%.

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     85.15%   85.15%           
- Complexity      737      747   +10     
=========================================
  Files           173      173           
  Lines          2742     2776   +34     
  Branches        155      157    +2     
=========================================
+ Hits           2335     2364   +29     
- Misses          326      329    +3     
- Partials         81       83    +2     
Impacted Files Coverage Δ
.../com/robothy/s3/rest/constants/AmzHeaderNames.java 0.00% <ø> (ø)
.../robothy/s3/rest/assertions/RequestAssertions.java 50.00% <25.00%> (-4.55%) ⬇️
.../com/robothy/s3/core/service/PutObjectService.java 94.73% <71.42%> (-5.27%) ⬇️
...om/robothy/s3/core/model/answers/GetObjectAns.java 100.00% <100.00%> (ø)
...3/core/model/internal/VersionedObjectMetadata.java 88.88% <100.00%> (+1.38%) ⬆️
...obothy/s3/core/model/request/PutObjectOptions.java 85.71% <100.00%> (+2.38%) ⬆️
...com/robothy/s3/core/service/CopyObjectService.java 100.00% <100.00%> (ø)
.../com/robothy/s3/core/service/GetObjectService.java 100.00% <100.00%> (ø)
...m/robothy/s3/rest/handler/GetObjectController.java 84.61% <100.00%> (+2.00%) ⬆️
.../robothy/s3/rest/handler/HeadObjectController.java 91.30% <100.00%> (+0.82%) ⬆️
... and 2 more

@@ -26,4 +27,6 @@ public class GetObjectAns {

private InputStream content;

private Map<String, String> userMetadata;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6% of developers fix this issue

UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.


Suggested change
private Map<String, String> userMetadata;
SuppressWarnings

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
local-s3-core/src/main/java/com/robothy/s3/core/model/request/PutObjectOptions.java 24
local-s3-core/src/main/java/com/robothy/s3/core/model/internal/VersionedObjectMetadata.java 34

Visit the Lift Web Console to find more details in your report.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@sonatype-lift
Copy link

sonatype-lift bot commented Jun 16, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/Robothy/local-s3/59.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/Robothy/local-s3/59.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@Robothy Robothy merged commit d4e6474 into master Jun 19, 2023
@Robothy Robothy deleted the ISSUE-58 branch June 19, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant