Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved bug in BlueROV2 Heavy and Heavy Reach launch configurations (backport #193) #195

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 25, 2024

Changes Made

This PR adds a few fixes: some of which were recognized while I was debugging the build for Humble yesterday. The changes are as follows:

  1. Fix the ardupilot_gazebo install. The dependencies have changed there and needed to be updated
  2. Stopped passing the robot description file directly to the controller manager. This has been deprecated by the ros2_control team and needed to be fixed
  3. Addressed a bad default path in the launch file for the BlueROV2 Heavy and Heavy Reach configurations

Associated Issues

Testing

Testing was performed using Iron and Humble. Jazzy and Rolling are still being upgraded, so everything is broken there right now.


This is an automatic backport of pull request #193 done by [Mergify](https://mergify.com).

…193)

* Fixed ardusub_gazebo install and mavros configurations

* Remapped controller manager topic to robot state publisher topic

* Added missing gstreamer dependency

(cherry picked from commit 9ddb154)
@evan-palmer evan-palmer merged commit e2b43c6 into humble Jun 25, 2024
3 checks passed
@evan-palmer evan-palmer deleted the mergify/bp/humble/pr-193 branch June 25, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant