Added Support for ESP32-S2 & ESP-S3, configurable frequency and radians #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can now instantiate ServoFloat and ServoDouble in addition to Servo. This is to allow using radians, which would get truncated with integers. Also when using degrees this is beneficial if you want better resolution than 1 degree. The implementation must be in the header file for template classes. ServoBase class is shared between all template versions of ServoTemplate, so the static variable channel_next_free is shared. Added an example for how to use ServoFloat with radians.
|
Hello @JarekParal is it possible to get this merged? |
JarekParal
approved these changes
Aug 29, 2023
|
@mikaeltulldahl Hello, thank you very much for your PR. All the changes seems to be good. I merged it and I'm going to release it as version 1.1 |
|
Great! If possible, could you also publish the update on PlatformIO with |
This was referenced Aug 30, 2023
|
Do you know if the automatic update of PlatformIO libraries still works or it has to be done only with |
|
I think it is a manual step. I see you did a release here on github but it
didn't became available on PlatformIO
…On Wed, 30 Aug 2023, 06:49 Jaroslav Páral, ***@***.***> wrote:
Do you know if the automatic update of PlatformIO libraries still works or
it has to be done only with pio pkq publish?
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEMWKZI2ZFD2K4TGJ4BSCDXX3A67ANCNFSM6AAAAAAXT2WGAM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
The automatic update from GitHub Release is still working on PIO: |
|
Ah yes, my mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fork from @h2zero incorporating a fix for ESP32-S2 which turned out to also fix the same problem for ESP32-S3, where the resolution was configured to too high in ledcSetup.
The changes are only tested on an ESP32-S3-DevKitC-1.
This should solve issue #18.
Added this functionality: