Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS] - Refactor RB-Pearl sensor tf #34

Open
wants to merge 2 commits into
base: ros-devel
Choose a base branch
from

Conversation

rafa-martin
Copy link
Member

Latest version for pearl, it publish points from base instead center of the sphere.

@RomanRobotnik
Copy link
Contributor

@rafa-martin when you say last version, does it means that in the past was different?

@rafa-martin
Copy link
Member Author

I would say, the version for this PR fixes the error I have.

@RomanRobotnik
Copy link
Contributor

Can you check if it still works for simulation in the same way?

@rafa-martin
Copy link
Member Author

No, it doesn't. It creates the rays from ${prefix}_link and isn't correct to start from base.
To keep backward compatibility, we can keep the same TF offset in urdf from ${prefix}_base_link. But:

  1. In simultation poincloud will be ${prefix}_link as frame_id in header field.
  2. In real, pointcloud message will be ${prefix}_base_link as frame_id in header field.

@rafa-martin
Copy link
Member Author

Revert previous commit, format xacro and remove M_PI variable in favor to use radians function from xacro

@rafa-martin rafa-martin changed the title [ROS] - Fix RB-Pearl sensor tf [ROS] - Refactor RB-Pearl sensor tf Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants