Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensia camera and PTZ standarization #35

Merged
merged 7 commits into from
Jul 22, 2024
Merged

Sensia camera and PTZ standarization #35

merged 7 commits into from
Jul 22, 2024

Conversation

RomanRobotnik
Copy link
Contributor

This PR aims:

  • Add new components for the Sensia camera and its pan-tilt
  • Add a prefix for all the PTZ cameras to identify the type of image: color or thermal
    • This modification will require to update the config files and packages for the real cameras

m-sanchez-rico
m-sanchez-rico approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@m-sanchez-rico m-sanchez-rico left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, I agree with the standardization of color/thermal topics. I will work on top of that.
@robert-ros Do you agree?

@alex-arnal alex-arnal merged commit 35b3bec into ros-devel Jul 22, 2024
@alex-arnal alex-arnal deleted the feat/add-sensia-camera branch July 22, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-sanchez-rico m-sanchez-rico m-sanchez-rico approved these changes

@robert-ros robert-ros Awaiting requested review from robert-ros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanRobotnik @m-sanchez-rico @alex-arnal