Skip to content

Commit

Permalink
Merge pull request #235 from Roche/dev
Browse files Browse the repository at this point in the history
version 1.2.3
  • Loading branch information
ofajardo committed Aug 21, 2023
2 parents 03214b8 + 042c32b commit 6cb0bee
Show file tree
Hide file tree
Showing 16 changed files with 34,125 additions and 21,383 deletions.
2 changes: 1 addition & 1 deletion CITATION.cff
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors:
given-names: "Otto"
orcid: "https://orcid.org/0000-0002-3363-9287"
title: "Pyreadstat"
version: 1.2.2
version: 1.2.3
doi: 10.5281/zenodo.6612282
date-released: 2018-09-24
url: "https://github.com/Roche/pyreadstat"
18 changes: 4 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,7 @@ You can also install from the github repo directly (without cloning). Use the fl
pip install git+https://github.com/Roche/pyreadstat.git
```

You need a working C compiler. If working in python 2.7 you will need
cython version >= 0.28 installed (see later Python 2.7 support). For python 3, cython
is not necessary if compiling on unix, but if installed it will be used.
You need a working C compiler and cython >=3.0.0.

### Compiling on Windows and Mac

Expand Down Expand Up @@ -870,17 +868,9 @@ Converting data types from foreign applications into python some times also brin

## Python 2.7 support.

Python 2.7 is not actively supported. If it works, we are happy about that. But if it does not, and the
bug is specific for python 2.7 (cannot be reproduced in python 3), the issue is not going to be solved.

At the moment of writing this document Python 2.7 does not work for windows.
It does work for Mac and Linux. In Mac and Linux, files cannot be opened
if the path contains international (non-ascii) characters. As mentioned
before this bug is not going to be repaired (There is not such issue on
Python 3).

Starting on version 1.0.6 wheels are not produced for Python 2.7 anymore,
but you can still compile on linux and mac.
As version 1.2.3 Python 2.7 is not supported. In previous versions it was possible to compile it for
mac and linux but not for windows, but no wheels were provided. In linux and mac it will fail if
the path file contains non-ascii characters.

## Change log

Expand Down
6 changes: 5 additions & 1 deletion change_log.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# 1.2.1 (github, pypi and conda 2023.06.01)
# 1.2.3 (github, pypi and conda 2023.07.xx)
* changes introduced for compatibility with cython 3.0.0. Cython 0.29 no longer supported.
Python 2.7 no longer supported.

# 1.2.2 (github, pypi and conda 2023.06.01)
* added num_rows to multiprocessing to allow processing of xport, por and
sav files not having the number of rows in the metadata.

Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
# The short X.Y version
version = ''
# The full version, including alpha/beta/rc tags
release = '1.2.2'
release = '1.2.3'


# -- General configuration ---------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion pyreadstat/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@
from .pyreadstat import read_file_in_chunks, read_file_multiprocessing
from ._readstat_parser import ReadstatError, metadata_container

__version__ = "1.2.2"
__version__ = "1.2.3"

Loading

0 comments on commit 6cb0bee

Please sign in to comment.