Merge pull request #249 from Roche/dev

v1.2.6
Roche · Dec 20, 2023 · b19d86e · b19d86e
2 parents 170554b + 19f0293
commit b19d86e
Show file tree

Hide file tree

Showing 14 changed files with 1,302 additions and 1,280 deletions.
diff --git a/CITATION.cff b/CITATION.cff
@@ -5,7 +5,7 @@ authors:
   given-names: "Otto"
   orcid: "https://orcid.org/0000-0002-3363-9287"
 title: "Pyreadstat"
-version: 1.2.5
+version: 1.2.6
 doi: 10.5281/zenodo.6612282
 date-released: 2018-09-24
 url: "https://github.com/Roche/pyreadstat"
diff --git a/change_log.md b/change_log.md
@@ -1,3 +1,6 @@
+# 1.2.5 (github, pypi and conda 2023.12.20)
+* correcting bug when writing files with character columns with all missing, character length set to 1
+
 # 1.2.5 (github, pypi and conda 2023.11.24)
 * Correcting bug for datetime64[us
 

diff --git a/docs/_build/doctrees/environment.pickle b/docs/_build/doctrees/environment.pickle
diff --git a/docs/_build/html/.buildinfo b/docs/_build/html/.buildinfo
@@ -1,4 +1,4 @@
 # Sphinx build info version 1
 # This file hashes the configuration used when building these files. When it is not found, a full rebuild will be done.
-config: 747f6e874f37f43245053c55564db6af
+config: c753dad9ecdd8cb110ace3bf962d3d4d
 tags: 645f666f9bcd5a90fca523b33c5a78b7
diff --git a/docs/_build/html/_static/documentation_options.js b/docs/_build/html/_static/documentation_options.js
@@ -1,6 +1,6 @@
 var DOCUMENTATION_OPTIONS = {
     URL_ROOT: document.getElementById("documentation_options").getAttribute('data-url_root'),
-    VERSION: '1.2.5',
+    VERSION: '1.2.6',
     LANGUAGE: 'None',
     COLLAPSE_INDEX: false,
     BUILDER: 'html',

diff --git a/docs/_build/html/genindex.html b/docs/_build/html/genindex.html
@@ -3,7 +3,7 @@
 <head>
   <meta charset="utf-8" />
   <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-  <title>Index &mdash; pyreadstat 1.2.5 documentation</title>
+  <title>Index &mdash; pyreadstat 1.2.6 documentation</title>
       <link rel="stylesheet" href="_static/pygments.css" type="text/css" />
       <link rel="stylesheet" href="_static/css/theme.css" type="text/css" />
   <!--[if lt IE 9]>

diff --git a/docs/_build/html/index.html b/docs/_build/html/index.html
@@ -4,7 +4,7 @@
   <meta charset="utf-8" /><meta name="generator" content="Docutils 0.17.1: http://docutils.sourceforge.net/" />
 
   <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-  <title>Welcome to pyreadstat’s documentation! &mdash; pyreadstat 1.2.5 documentation</title>
+  <title>Welcome to pyreadstat’s documentation! &mdash; pyreadstat 1.2.6 documentation</title>
       <link rel="stylesheet" href="_static/pygments.css" type="text/css" />
       <link rel="stylesheet" href="_static/css/theme.css" type="text/css" />
   <!--[if lt IE 9]>

diff --git a/docs/_build/html/py-modindex.html b/docs/_build/html/py-modindex.html
@@ -3,7 +3,7 @@
 <head>
   <meta charset="utf-8" />
   <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-  <title>Python Module Index &mdash; pyreadstat 1.2.5 documentation</title>
+  <title>Python Module Index &mdash; pyreadstat 1.2.6 documentation</title>
       <link rel="stylesheet" href="_static/pygments.css" type="text/css" />
       <link rel="stylesheet" href="_static/css/theme.css" type="text/css" />
   <!--[if lt IE 9]>

diff --git a/docs/_build/html/search.html b/docs/_build/html/search.html
@@ -3,7 +3,7 @@
 <head>
   <meta charset="utf-8" />
   <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-  <title>Search &mdash; pyreadstat 1.2.5 documentation</title>
+  <title>Search &mdash; pyreadstat 1.2.6 documentation</title>
       <link rel="stylesheet" href="_static/pygments.css" type="text/css" />
       <link rel="stylesheet" href="_static/css/theme.css" type="text/css" />
 

diff --git a/docs/conf.py b/docs/conf.py
@@ -26,7 +26,7 @@
 # The short X.Y version
 version = ''
 # The full version, including alpha/beta/rc tags
-release = '1.2.5'
+release = '1.2.6'
 
 
 # -- General configuration ---------------------------------------------------

diff --git a/pyreadstat/__init__.py b/pyreadstat/__init__.py
@@ -20,5 +20,5 @@
 from .pyreadstat import read_file_in_chunks, read_file_multiprocessing
 from ._readstat_parser import ReadstatError, metadata_container
 
-__version__ = "1.2.5"
+__version__ = "1.2.6"
 
diff --git a/pyreadstat/_readstat_writer.c b/pyreadstat/_readstat_writer.c
diff --git a/pyreadstat/_readstat_writer.pyx b/pyreadstat/_readstat_writer.pyx
@@ -148,7 +148,7 @@ cdef int get_pandas_str_series_max_length(object series, dict value_labels):
     values = series.values
     cdef str val
     cdef bytes temp
-    cdef int max_length = 0
+    cdef int max_length = 1
     cdef int curlen
     cdef list labels
     for val in values:
@@ -278,6 +278,7 @@ cdef list get_pandas_column_types(object df, dict missing_user_values, dict vari
                 if is_missing:
                     col = curseries.dropna().reset_index(drop=True)
                     max_length = get_pandas_str_series_max_length(col, variable_value_labels.get(col_name))
+                    max_length = max(1, max_length)
                 else:
                     max_length = get_pandas_str_series_max_length(curseries, variable_value_labels.get(col_name))
                 result.append((PYWRITER_CHARACTER, max_length, is_missing))

diff --git a/setup.py b/setup.py
@@ -127,7 +127,7 @@
 
 setup(
     name='pyreadstat',
-    version='1.2.5',
+    version='1.2.6',
     description=short_description,
     author="Otto Fajardo",
     author_email="pleasecontactviagithub@notvalid.com",