pull newest #3
Merged
pull newest #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Add async method: `binarySearch` and `btreeSearch`. 2) Refactor of tests by putting them into `tests` folder. 3) Create several new tests in details. 4) Remove useless and reformat codes to be clear. 5) Remove useless snapshots, because they can be recreated when you run `npm run test`.
Because the async is the wrapper of Task, we don't need to use async again.
Code Refactoring
New Feature of async for Nodejs, Refactor of codes in node.js
1) Considering using xUnit for UnitTest, remove my unit tests. 2) Remove useless `async`, because `async` is just the wrapper of `Task`. 3) Modify unit tests to be sure that the values MUST BE equal to each other when the IP is the same.
[Update] Refactor codes according to RocherHong's changes
`_search` should release resouces because the file state is still open.
[Fix] Add "Disposible" interface for final release of resouces
1) In `README.md`, we shouldn't use `c#` but `csharp` to make md recoginize it's the C# formation of codes. 2) Add 'ConfigureAwait(false)' as for the MSDN magazine usage. 3) Don't need Contribution History in README.md, because we can see the change logs in GitHub instead.
[Fix] Fix csharp formations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.