Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Multiprocessing Helpers #117

Merged
merged 37 commits into from
Sep 8, 2022
Merged

Add Python Multiprocessing Helpers #117

merged 37 commits into from
Sep 8, 2022

Conversation

clee-ai
Copy link
Contributor

@clee-ai clee-ai commented Sep 6, 2022

No description provided.

@clee-ai clee-ai requested a review from leo-stan September 6, 2022 23:34
Copy link
Contributor

@leo-stan leo-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! looks really good! Could we add a bunch more comments in the code? I feel like future us will be happy when we have to dive back into them later.

return points


def rotate_file_mp():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a ton of comments to this function? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if that's better!

example/example_mp.py Outdated Show resolved Hide resolved
python/copclib/mp/read.py Show resolved Hide resolved
Copy link
Contributor

@leo-stan leo-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice! Love all the comments 😸

test/utils.py Show resolved Hide resolved
test/utils.py Outdated
# Create a point with a given point format
point = points.CreatePoint()
# point has getters/setters for all attributes
point.X = random.randint(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to get updated once #119 is merged

@clee-ai clee-ai merged commit 0beabe7 into main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants