Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-1402: LAZ reader #128

Merged
merged 14 commits into from
Oct 12, 2022
Merged

FEAT-1402: LAZ reader #128

merged 14 commits into from
Oct 12, 2022

Conversation

leo-stan
Copy link
Contributor

No description provided.

@leo-stan
Copy link
Contributor Author

leo-stan commented Oct 8, 2022

Done by Chris

@leo-stan leo-stan closed this Oct 8, 2022
@leo-stan leo-stan reopened this Oct 11, 2022
@leo-stan leo-stan marked this pull request as ready for review October 11, 2022 20:55
leo-stan
leo-stan commented Oct 12, 2022
View reviewed changes
Copy link
Contributor Author

@leo-stan leo-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super good stuff!

cpp/src/io/base_reader.cpp Outdated Show resolved Hide resolved
cpp/src/io/base_reader.cpp Outdated Show resolved Hide resolved
cpp/src/io/base_reader.cpp Outdated Show resolved Hide resolved
cpp/src/io/base_reader.cpp Outdated Show resolved Hide resolved
cpp/include/copc-lib/io/base_reader.hpp Show resolved Hide resolved
cpp/include/copc-lib/io/laz_reader.hpp Show resolved Hide resolved
cpp/include/copc-lib/copc/copc_config.hpp Show resolved Hide resolved
cpp/src/io/copc_reader.cpp Show resolved Hide resolved
@leo-stan
Copy link
Contributor Author

leo-stan commented Oct 12, 2022 •
edited
Loading

I wonder if we should reach out to the laspy peeps now that we have a LAZ reader/writer for cpp, they might reference copclib as alternative for cpp

@CCInc @leo-stan
Apply suggestions from code review
8abdf5b 
Co-authored-by: Leo Stanislas <leo.stanislas@gmail.com>
@CCInc
Copy link
Contributor

CCInc commented Oct 12, 2022

Eh, it's not fully featured in any way. Just works well enough for me 😄

@CCInc CCInc merged commit 3043620 into main Oct 12, 2022
@CCInc CCInc deleted the laz_reader branch October 12, 2022 20:30
@hobu
Copy link
Contributor

hobu commented Oct 13, 2022

I wonder if we should reach out to the laspy peeps now that we have a LAZ reader/writer for cpp, they might reference copclib as alternative for cpp

Given that the laspy maintainer is the lazrs developer and uses that for laspy now, I doubt there would be much interest. btw, laspy has local/remote COPC read support now, but the write side is of course more complicated and not available in laspy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CCInc CCInc CCInc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo-stan @CCInc @hobu