Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output operator overrides to classes with ToString #134

Merged
merged 6 commits into from
Oct 17, 2022
Merged

Add output operator overrides to classes with ToString #134

merged 6 commits into from
Oct 17, 2022

Conversation

CCInc
Copy link
Contributor

@CCInc CCInc commented Oct 14, 2022

No description provided.

@CCInc CCInc requested a review from leo-stan October 14, 2022 21:49
leo-stan
leo-stan reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@leo-stan leo-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice touch! I think we're missing Extents, Info, Point, and Points in the tests.

leo-stan
leo-stan approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@leo-stan leo-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@CCInc CCInc merged commit 816f0a8 into main Oct 17, 2022
@CCInc CCInc deleted the output-ops branch October 17, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-stan leo-stan leo-stan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CCInc @leo-stan