Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-449: Resolution query functions #48

Merged
merged 23 commits into from
Oct 5, 2021
Merged

FEAT-449: Resolution query functions #48

merged 23 commits into from
Oct 5, 2021

Conversation

leo-stan
Copy link
Contributor

No description provided.

@leo-stan leo-stan marked this pull request as draft September 28, 2021 17:11
@leo-stan leo-stan marked this pull request as ready for review September 28, 2021 20:18
@leo-stan leo-stan requested a review from CCInc September 28, 2021 20:18
CCInc
CCInc reviewed Sep 28, 2021
View reviewed changes
example/example-writer.cpp Outdated Show resolved Hide resolved
example/example-writer.cpp Show resolved Hide resolved
@leo-stan leo-stan changed the title FEAT-440: Resolution query functions FEAT-449: Resolution query functions Oct 1, 2021
CCInc
CCInc reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@CCInc CCInc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

include/copc-lib/io/reader.hpp Outdated Show resolved Hide resolved
include/copc-lib/io/reader.hpp Outdated Show resolved Hide resolved
include/copc-lib/io/reader.hpp Outdated Show resolved Hide resolved
include/copc-lib/io/reader.hpp Outdated Show resolved Hide resolved
src/io/reader.cpp Outdated Show resolved Hide resolved
src/io/reader.cpp Outdated Show resolved Hide resolved
test/reader_test.py Outdated Show resolved Hide resolved
@CCInc
Copy link
Contributor

CCInc commented Oct 5, 2021

pre-commit.ci autofix

CCInc
CCInc approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@CCInc CCInc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feel free to merge after addressing these!

cpp/include/copc-lib/hierarchy/key.hpp Outdated Show resolved Hide resolved
cpp/src/hierarchy/key.cpp Outdated Show resolved Hide resolved
cpp/src/io/reader.cpp Outdated Show resolved Hide resolved
cpp/src/io/reader.cpp Show resolved Hide resolved
cpp/src/io/reader.cpp Outdated Show resolved Hide resolved
cpp/src/io/reader.cpp Outdated Show resolved Hide resolved
example/example-writer.cpp Outdated Show resolved Hide resolved
example/example-writer.py Show resolved Hide resolved
python/bindings.cpp Outdated Show resolved Hide resolved
test/reader_test.cpp Outdated Show resolved Hide resolved
@CCInc
Copy link
Contributor

CCInc commented Oct 5, 2021

pre-commit.ci run

@CCInc
Copy link
Contributor

CCInc commented Oct 5, 2021

pre-commit.ci autofix

1 similar comment
@CCInc
Copy link
Contributor

CCInc commented Oct 5, 2021

pre-commit.ci autofix

@CCInc CCInc closed this Oct 5, 2021
@CCInc CCInc reopened this Oct 5, 2021
@CCInc CCInc merged commit e9b7c5e into RockRobotic:main Oct 5, 2021
@leo-stan leo-stan deleted the FEAT-440_spatial2 branch October 5, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CCInc CCInc CCInc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-stan @CCInc