Remove /terms endpoint and update filter fields #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would suggest leaving the Views and Serializers in place, but removing the URL from the router and templates (as you've done). That should resolve the failing tests and also leave that code in place for when we need it, which might be sooner than we think... |
helrond
requested changes
Feb 17, 2022
helrond
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188 and #187
I think I've gone too far in removing
/termshere? This is probably something that we'll want to add back in in the future when data is better, and maybe I shouldn't be trying to take all of this out, but just keep it out of the browseable API?Also, as evidenced by the failing tests I'm having trouble extracting this gracefully. I'd appreciate some help focusing what I should be trying to do to solve issue #187 .