Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable user to enter custom prompt #11

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

AmanNegi
Copy link
Collaborator

@AmanNegi AmanNegi commented Jun 25, 2024

Description

  • Usually normal users would be relying on the LLM for prompt generation but power users who wish to enter their own prompt an now mention p or prompt as the first argument and pass their prompt as the second argument.
  • This provides the power user a finer control over the prompt and in turn the output.

Preview

Screenshot from 2024-06-25 14-18-33

The power user can preview the GIF generation directly in the preview section.

Fixes #10

@Nabhag8848 please let me know if this seems fine and if any changes are required.

@Nabhag8848
Copy link
Collaborator

@AmanNegi lemme know once you resolve this conflicts

Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmanNegi Added few comments, lemme know once you are done.

src/commands/GenGifCommand.ts Outdated Show resolved Hide resolved
src/lib/GifRequestDispatcher.ts Outdated Show resolved Hide resolved
- includes minor refactoring changes, and simplification of
  GenGifCommand class.
Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definition/command/ICommandUtility.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definition/command/ICommandUtility.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmanNegi LGTM

@Nabhag8848 Nabhag8848 merged commit 84677ae into RocketChat:main Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] allow users an option to specify a prompt if they want to
2 participants