Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to view past generations #12

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

AmanNegi
Copy link
Collaborator

@AmanNegi AmanNegi commented Jul 4, 2024

Description

Allows users to view past generations. Implemented using IPersistence and storing the generations using multiple associations. The generations are uniquely stored for each user, and can be viewed by passing h or history as the first parameter to the gen-gif command.

Preview

history-demo.1.mp4

Fixes: #3

@AmanNegi AmanNegi self-assigned this Jul 4, 2024
@AmanNegi AmanNegi requested a review from Nabhag8848 July 4, 2024 14:58
@Nabhag8848
Copy link
Collaborator

@AmanNegi Merge Conflicts

@AmanNegi
Copy link
Collaborator Author

AmanNegi commented Jul 7, 2024

@Nabhag8848 I have fixed the merge conflicts, could you please look into this.

Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/persistence/GenerationPersistence.ts Outdated Show resolved Hide resolved
- refactors associations as a private object in
  `GenerationPersistence.ts`.
Copy link
Collaborator

@Nabhag8848 Nabhag8848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @AmanNegi

@Nabhag8848 Nabhag8848 merged commit edacf9b into RocketChat:main Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Allow users to view previous generations
2 participants