Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented workflow to deploy preview of pr changes #620

Merged

Conversation

devanshkansagra
Copy link
Contributor

@devanshkansagra devanshkansagra commented Sep 4, 2024

Pull Request Preview Deployment to GitHub Pages

Acceptance Criteria fulfillment

  • Deploy every pull request builds of monorepo to a unique url
  • Remove Deployment when PR is merged and closed

Fixes #617

Video/Screenshots

image

@Spiral-Memory
Copy link
Collaborator

Hey @devanshkansagra
Mark this PR as a draft until ready !!

@devanshkansagra devanshkansagra marked this pull request as draft September 4, 2024 12:32
@devanshkansagra devanshkansagra marked this pull request as ready for review September 14, 2024 18:12
@devanshkansagra
Copy link
Contributor Author

Hey, maintainers and @Spiral-Memory can you please review my pull request? If there are any changes to be made, I will follow up

@Spiral-Memory
Copy link
Collaborator

Hey @devanshkansagra
Let me know the progress !

@devanshkansagra
Copy link
Contributor Author

devanshkansagra commented Sep 26, 2024

Hey @Spiral-Memory, currently this PR is able to add and remove the pr deployments of react and ui-elements. Also I am researching about to deploy layout_editor and docs, which was not possible as we disscussed earlier. If I found the way I will update

@Spiral-Memory
Copy link
Collaborator

Sure, let me know once it's ready for review ! We do need docs and layout_editor deployment as well. Hope this new way works 🥹

@devanshkansagra
Copy link
Contributor Author

Okay sure I will let you know if the fix I found

@Spiral-Memory Spiral-Memory added the epic this is a must have feature label Sep 29, 2024
- name: Install Dependencies
run: yarn

- name: Filter the packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter packages?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it checks that which package of monorepo has changes if there is change in react monorepo then it will deploy only react one, if there is change in ui-elements it will deploy only ui-elements and so on..

@Spiral-Memory
Copy link
Collaborator

Check why deploy PR is failing

@Spiral-Memory
Copy link
Collaborator

Merging it for testing, will revert the change if it doesn't work

@Spiral-Memory Spiral-Memory merged commit 05c0f2d into RocketChat:develop Sep 30, 2024
3 of 4 checks passed
@Spiral-Memory
Copy link
Collaborator

Reverting the PR as it is not working for unmerged PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic this is a must have feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] : Deploy PR Previews to GitHub Pages
2 participants