-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented workflow to deploy preview of pr changes #620
Implemented workflow to deploy preview of pr changes #620
Conversation
Hey @devanshkansagra |
Hey, maintainers and @Spiral-Memory can you please review my pull request? If there are any changes to be made, I will follow up |
Hey @devanshkansagra |
Hey @Spiral-Memory, currently this PR is able to add and remove the pr deployments of react and ui-elements. Also I am researching about to deploy layout_editor and docs, which was not possible as we disscussed earlier. If I found the way I will update |
Sure, let me know once it's ready for review ! We do need |
Okay sure I will let you know if the fix I found |
- name: Install Dependencies | ||
run: yarn | ||
|
||
- name: Filter the packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filter packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it checks that which package of monorepo has changes if there is change in react monorepo then it will deploy only react one, if there is change in ui-elements it will deploy only ui-elements and so on..
Check why deploy PR is failing |
Merging it for testing, will revert the change if it doesn't work |
Reverting the PR as it is not working for unmerged PRs |
Pull Request Preview Deployment to GitHub Pages
Acceptance Criteria fulfillment
Fixes #617
Video/Screenshots