[Fix] Pin icon should not be visible to users without pin permission (revised) #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Spiral-Memory @sidmohanty11 please have a look. |
| userRoles.length > 0 && | ||
| postMsgRoles.some((role) => userRoles.includes(role)); | ||
| setCanSendMsg(canSendMsg); | ||
| const concatenatedRoles = channelMemberRoles.concat( |
There was a problem hiding this comment.
You can use shorthand here, destructure and combine. I have raised a PR feat: Addition of chatinfo to display status, have a look here..
There was a problem hiding this comment.
Hey @Spiral-Memory, can you share that pr number?
There was a problem hiding this comment.
Hey @Spiral-Memory, if we destructure and combine, the users are unable to login
| @@ -235,6 +235,7 @@ const Message = ({ | |||
| {!message.t && showToolbox ? ( | |||
| <MessageToolbox | |||
| message={message} | |||
| RCInstance={RCInstance} | |||
There was a problem hiding this comment.
Why is this added ? Any specific reason?
There was a problem hiding this comment.
Hey @Spiral-Memory the adding of RCInstance as a prop was unnecessary, after removing it I have seen no change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Pin icon should not be visible to users without the pin permission like in main Rocket.Chat application.
Check #518, #519 and #520 for complete details
Acceptance Criteria fulfillment
Fixes #519
Video/Screenshots
P.S: This PR is a revision of #520 after #518 is merged. Following this, #520 will be discarded.