Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feat: improve theme & style code #618

Merged
merged 14 commits into from
Sep 11, 2024

Conversation

Spiral-Memory
Copy link
Contributor

@Spiral-Memory Spiral-Memory commented Aug 23, 2024

Brief Title

This PR improves the code slightly for better readability and consistency.

Acceptance Criteria Fulfillment

  • Slightly modified the theme structure by moving radius and commonColors to the root level.
  • Updated how the useTheme hook provides colors and invertedColors explicitly; now theme.colors must be used.
  • Consolidated multiple key exports into a single style object export.
  • Converted style hooks to standard getXYZStyle functions.
  • Updated docs & added try it out for all live projects

Fixes: N/A

@Spiral-Memory Spiral-Memory changed the title feat: improve theme & style code fix/feat: improve theme & style code Aug 23, 2024
@Spiral-Memory Spiral-Memory force-pushed the feat/improve-theme-code branch 2 times, most recently from 86ecb8f to 9f94efd Compare August 23, 2024 12:19
@Spiral-Memory Spiral-Memory force-pushed the feat/improve-theme-code branch 2 times, most recently from 029f727 to 8ea5bfe Compare August 26, 2024 16:53
@Spiral-Memory Spiral-Memory force-pushed the feat/improve-theme-code branch 3 times, most recently from 7a0378b to f2e00df Compare September 5, 2024 05:43
@Spiral-Memory
Copy link
Contributor Author

This PR is ready to merge. I’ve made some minor code updates and adjusted the theme and style implementations. The documentation has been updated to reflect these changes, including the addition of demo links in the README and other relevant documents.

@sidmohanty11 sidmohanty11 merged commit 171a989 into RocketChat:develop Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants