-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/feat: improve theme & style code #618
Merged
sidmohanty11
merged 14 commits into
RocketChat:develop
from
Spiral-Memory:feat/improve-theme-code
Sep 11, 2024
Merged
fix/feat: improve theme & style code #618
sidmohanty11
merged 14 commits into
RocketChat:develop
from
Spiral-Memory:feat/improve-theme-code
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiral-Memory
changed the title
feat: improve theme & style code
fix/feat: improve theme & style code
Aug 23, 2024
Spiral-Memory
force-pushed
the
feat/improve-theme-code
branch
2 times, most recently
from
August 23, 2024 12:19
86ecb8f
to
9f94efd
Compare
Spiral-Memory
force-pushed
the
feat/improve-theme-code
branch
from
August 26, 2024 10:55
9faf3c7
to
1e48807
Compare
Spiral-Memory
force-pushed
the
feat/improve-theme-code
branch
2 times, most recently
from
August 26, 2024 16:53
029f727
to
8ea5bfe
Compare
Spiral-Memory
force-pushed
the
feat/improve-theme-code
branch
from
August 26, 2024 18:01
a5a2712
to
d4214c4
Compare
Spiral-Memory
force-pushed
the
feat/improve-theme-code
branch
3 times, most recently
from
September 5, 2024 05:43
7a0378b
to
f2e00df
Compare
…g, and demo.qa doesn't support anonymousMode
This PR is ready to merge. I’ve made some minor code updates and adjusted the theme and style implementations. The documentation has been updated to reflect these changes, including the addition of demo links in the README and other relevant documents. |
sidmohanty11
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
This PR improves the code slightly for better readability and consistency.
Acceptance Criteria Fulfillment
radius
andcommonColors
to the root level.useTheme
hook providescolors
andinvertedColors
explicitly; nowtheme.colors
must be used.getXYZStyle
functions.Fixes: N/A