Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: emoji parsing issue in file description #624

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

devanshkansagra
Copy link
Contributor

Acceptance Criteria fulfillment

  • Fixed emoji parsing issue

Fixes #623

Video/Screenshots

Screencast.from.16-09-24.06.05.40.PM.IST.webm

@Spiral-Memory
Copy link
Collaborator

Hey @devanshkansagra
Thanks for the contribution but i don't think this is necessary.

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, but still this is a small bug, and it seems that there is inconsistency so I raised the PR

@Spiral-Memory Spiral-Memory merged commit 2d158a9 into RocketChat:develop Sep 26, 2024
3 checks passed
@Spiral-Memory
Copy link
Collaborator

Sure ! Thanks for the contribution 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to parse emojis in file description in attachment preview
2 participants