Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[FEATURE] Client Certificate authentication #2007

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

DeviaVir
Copy link

@DeviaVir DeviaVir commented Jan 25, 2019

@RocketChat/android

Related to #1851

Disclaimer: I am very far removed from being an android or indeed mobile developer, please view this PR as a WIP, I am very open for feedback and changing this in a way that will make it something the Rocket.Chat team would like to merge and support, versus us keeping a local copy and merging in your changes every time.

Changes:

  • added Select Client Certificate button
  • added override interceptor
  • added clientCertHelper and various links to this helper

It allows for the app to perform as usual with servers protected behind client certificates.

Known bugs:

  • Requests to /websocket all still seem to fail due to not sending the correct certificate, though I'm unsure of the impact of this. The app seems to perform as usual.

Screenshots or GIF for the change:

Video showcasing client cert selector
(blurring is on purpose 😉)

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nklock
Copy link

nklock commented Apr 3, 2019

This is excellent news, our reverse proxy server requires users to us a client certificate as part of two factor authentication. This has worked well for web clients, but now we will be able to use mobile devices as well once this change is merged.

@DeviaVir
Copy link
Author

DeviaVir commented Apr 8, 2019

@nklock I wouldn't bank on this actually making the cut. You can always generate and release your own app in-house, like we've done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants