New "essentials" mechanism #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## new-room-events #269 +/- ##
===================================================
- Coverage 54.57% 53.66% -0.92%
===================================================
Files 82 82
Lines 2904 2909 +5
Branches 415 421 +6
===================================================
- Hits 1585 1561 -24
- Misses 1319 1348 +29
Continue to review full report at Codecov.
|
rodrigok
requested changes
May 13, 2020
rodrigok
approved these changes
May 16, 2020
d-gubert
added a commit
that referenced
this pull request
May 19, 2020
* Fix security problem * Add IPreRoomUserJoined event * Add the IPostRoomUserJoined event * New "essentials" mechanism (#269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
This is a mechanism that allows an app to register itself as "essential" to an event in the Rocket.Chat lifecycle.
If an app that is "essential" is disabled during the execution of such event, an error is thrown.
Why? 🤔
Currently, we have a problem regarding the state management of apps in HA setups. Each instance in the cluster has to manage the apps that are enabled/disabled, and should communicate any changes to the other instances when they happen, but this has shown to be unreliable in times when there is high usage.
This mechanism presents a way of "shielding" workspaces that require custom rules for critical events (message sending, room creating, etc.) to take place from this unpredictable problems.
Links 🌎
RocketChat/Rocket.Chat#17656
PS 👀