feat : Add initial SDK support for Rich Messaging (ButtonActions as Attachment) #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
@Shailesh351 Could you please sign the CLA so we can review this PR? |
luciofm
suggested changes
Aug 7, 2018
| if (it is ButtonAction) { | ||
| writer.beginObject() | ||
| writer.name("type").value(it.type) | ||
| it.text?.run { writer.name("text").value(it.text) } |
There was a problem hiding this comment.
If the values can be nullable, you can just write null to the JSON.
Or let's use .let to keep consistency with the rest of the file.
it.text?.let { writer.name("text").value(it) }
|
@luciofm Updated PR with requested changes. Please review. Thanks!! |
|
merged with some fixes in indentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification : https://github.com/WideChat/Rocket.Chat.Android/wiki/Buttons-Inside-Attachment-Object-Spec
Test : https://github.com/WideChat/Rocket.Chat.Android/wiki/(WIP)--Rich-Messaging-Acceptance-Test