Prevent pending updates error

RocketChat · Feb 19, 2020 · 90834ad · 90834ad
1 parent 2fbc90e
commit 90834ad
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/app/lib/methods/subscriptions/rooms.js b/app/lib/methods/subscriptions/rooms.js
@@ -242,12 +242,12 @@ export default function subscribeRooms() {
 					log(e);
 				}
 			} else {
-				// debouncedUpdateSub(data);
+				debouncedUpdateSub(data);
 			}
 		}
 		if (/rooms/.test(ev)) {
 			if (type === 'updated' || type === 'inserted') {
-				// debouncedUpdateRoom(data);
+				debouncedUpdateRoom(data);
 			}
 		}
 		if (/message/.test(ev)) {

diff --git a/app/lib/methods/updateMessages.js b/app/lib/methods/updateMessages.js
@@ -74,17 +74,29 @@ export default function updateMessages({ rid, update = [], remove = [] }) {
 			// Update
 			msgsToUpdate = msgsToUpdate.map((message) => {
 				const newMessage = update.find(m => m._id === message.id);
+				if (message._hasPendingUpdate) {
+					console.log(message);
+					return;
+				}
 				return message.prepareUpdate(protectedFunction((m) => {
 					Object.assign(m, newMessage);
 				}));
 			});
 			threadsToUpdate = threadsToUpdate.map((thread) => {
+				if (thread._hasPendingUpdate) {
+					console.log(thread);
+					return;
+				}
 				const newThread = allThreads.find(t => t._id === thread.id);
 				return thread.prepareUpdate(protectedFunction((t) => {
 					Object.assign(t, newThread);
 				}));
 			});
 			threadMessagesToUpdate = threadMessagesToUpdate.map((threadMessage) => {
+				if (threadMessage._hasPendingUpdate) {
+					console.log(threadMessage);
+					return;
+				}
 				const newThreadMessage = allThreadMessages.find(t => t._id === threadMessage.id);
 				return threadMessage.prepareUpdate(protectedFunction((tm) => {
 					Object.assign(tm, newThreadMessage);

diff --git a/app/lib/rocketchat.js b/app/lib/rocketchat.js
@@ -1096,7 +1096,7 @@ const RocketChat = {
 					InteractionManager.runAfterInteractions(() => {
 						reduxStore.dispatch(setActiveUsers(activeUsers));
 					});
-					// this.sdk.subscribe('stream-notify-logged', 'user-status');
+					this.sdk.subscribe('stream-notify-logged', 'user-status');
 					return resolve();
 				}
 			}