Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usernames removed from message using /me #5302

Open
paulchen opened this issue Oct 26, 2023 · 7 comments · May be fixed by #5367
Open

Usernames removed from message using /me #5302

paulchen opened this issue Oct 26, 2023 · 7 comments · May be fixed by #5367

Comments

@paulchen
Copy link

Description:

When writing a message starting with /me, any usernames will be removed from this message when rendering it.

Environment Information:

  • Rocket.Chat Server Version: 6.4.3
  • Rocket.Chat App Version: 4.42.0.50842
  • Device Name: ELE-L29 (Huawei P30)
  • OS Version: EMUI 12.0.0 (Android 11)

Steps to reproduce:

  1. Write a message using the /me command highlighting any user.

Expected behavior:

The message will be rendered containing the username. The browser version of Rocket.Chat works like this:

image

Actual behavior:

The message will be rendered without the username:

SVID_20231027_012620_1.mp4
@diegolmello
Copy link
Member

Can I ask what have you been using /me for?

@paulchen
Copy link
Author

paulchen commented Oct 27, 2023

Can I ask what have you been using /me for?

Nothing special.

A user on my Rocket.Chat server wrote a message like I need support with <topic> to which I replied /me will talk to <other user> about it, quoting the first message. I observed that this did not lead to what I expected, in several ways. I broke down everything I noticed into four different things and opened issues for them: #5300, #5301, #5302, and RocketChat/Rocket.Chat#30779.

I also don't think that these issues really have high importance. However, Rocket.Chat contains many of such small issues. The users on my server more and more have the feeling that Rocket.Chat lacks a certain level of quality. I decided to create issues for everything that I deem unexpected and that I can reproduce, hoping to be able to contribute to make Rocket.Chat an even better piece of software. It is up to the Rocket.Chat team to decide if, how and when they fix these issues.

If you don't like these issues, just be patient: I have not yet reported all the items from my list of Rocket.Chat problems. I just need to find the time to create issues for them.

@diegolmello
Copy link
Member

diegolmello commented Oct 27, 2023

Perhaps your expectation of /me is different from what the app is supposed to be?
I've never used the app, so I can't tell, but I can ask around.
What I can tell you is that we've been refining some tasks to provide a better support to apps on mobile.
The apps ecosystem has been evolving too fast and we've been neglecting the mobile support a little bit.

If you don't like these issues, just be patient: I have not yet reported all the items from my list of Rocket.Chat problems. I just need to find the time to create issues for them.

😂

Please keep reporting. We're always open to feedback and constantly polishing the product.

@paulchen
Copy link
Author

Perhaps your expectation of /me is different from what the app is supposed to be?

I don't know how /me should behave in detail. It was introduced to Rocket.Chat in RocketChat/Rocket.Chat#142, but I guess there might be edge cases that have never been considered.

At least I would expect not to be confused by what actually happens when I try to use /me.

@brf153
Copy link
Contributor

brf153 commented Nov 24, 2023

@paulchen It's actually weird because it is working fine in the desktop app, but it shows an error in the mobile app. I will work on this issue.

@brf153
Copy link
Contributor

brf153 commented Nov 27, 2023

I think I have figured out the error. When using Markdown formatting for features like italics, bold, etc., mentions using '@' are getting removed.

@brf153
Copy link
Contributor

brf153 commented Nov 27, 2023

I am working on it and will raise a pr for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants