Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Use autoFocus rather than timeout + focus #1071

Merged
merged 5 commits into from
Aug 7, 2019
Merged

[IMPROVEMENT] Use autoFocus rather than timeout + focus #1071

merged 5 commits into from
Aug 7, 2019

Conversation

tanujsinghkushwah
Copy link
Contributor

@RocketChat/ReactNative

Closes #1067

@diegolmello
Copy link
Member

Thanks for your PR, @tj4752!
It looks ok, but I'm going to review it properly only next week.
We're finishing last steps of 1.17.0 and we're going to release it by monday/tuesday.
Cheers.

IlarionHalushka
IlarionHalushka suggested changes Aug 3, 2019
View reviewed changes
app/views/SetUsernameView.js Outdated Show resolved Hide resolved
app/views/SearchMessagesView/index.js Outdated Show resolved Hide resolved
app/views/RegisterView.js Outdated Show resolved Hide resolved
app/views/NewServerView.js Outdated Show resolved Hide resolved
app/views/SearchMessagesView/index.js Outdated Show resolved Hide resolved
app/views/ForgotPasswordView.js Outdated Show resolved Hide resolved
app/views/CreateChannelView.js Outdated Show resolved Hide resolved
diegolmello
diegolmello approved these changes Aug 7, 2019
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 7b2185d into RocketChat:develop Aug 7, 2019
@diegolmello
Copy link
Member

@tj4752 Merged. Thank you! 👊

djorkaeffalexandre pushed a commit that referenced this pull request Aug 9, 2019
@tanujsinghkushwah @diegolmello
[IMPROVEMENT] Use autoFocus rather than timeout + focus (#1071)
c87cbfe 
* autofocus replaced timout+focus

* removed inputRef

* Unnecessary focus on NewServerView when passing server as props

* Removed unnecessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlarionHalushka IlarionHalushka IlarionHalushka requested changes

@diegolmello diegolmello diegolmello approved these changes

Assignees
No one assigned
Labels
👍 improvement 👀 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Use autoFocus rather than timeout + focus
4 participants
@tanujsinghkushwah @diegolmello @IlarionHalushka @djorkaeffalexandre