Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] SAML authentication support #1108

Merged
merged 12 commits into from
Aug 9, 2019
Merged

[NEW] SAML authentication support #1108

merged 12 commits into from
Aug 9, 2019

Conversation

philipbrito
Copy link
Contributor

@RocketChat/ReactNative

Closes #428

To be merged after #1093.

@philipbrito philipbrito self-assigned this Aug 6, 2019
app/views/SSOView.js Outdated Show resolved Hide resolved
# Conflicts:
#	app/lib/rocketchat.js
#	app/views/LoginSignupView.js
@lgtm-com
Copy link

lgtm-com bot commented Aug 7, 2019

This pull request introduces 1 alert when merging 1838174 into 6a3523d - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 59426f4 into develop Aug 9, 2019
@diegolmello diegolmello deleted the new/saml branch August 9, 2019 17:28
@ggazzo
Copy link
Member

ggazzo commented Aug 10, 2019

@diegolmello @filipedelimabrito should we update?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authentication via SAML is missing
5 participants