Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove react-native global installs #1886

Merged
merged 5 commits into from
Mar 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,6 @@ jobs:
name: Restore NPM cache
key: node-modules-{{ checksum "yarn.lock" }}

- run:
name: Install React Native CLI
command: |
npm i -g react-native-cli

- run:
name: Install NPM modules
command: |
Expand Down Expand Up @@ -308,7 +303,6 @@ jobs:
- run:
name: Install NPM modules
command: |
yarn global add react-native react-native-cli
yarn

- run:
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,15 @@ Follow the [React Native Getting Started Guide](https://facebook.github.io/react
```bash
$ git clone git@github.com:RocketChat/Rocket.Chat.ReactNative.git
$ cd Rocket.Chat.ReactNative
$ yarn global add react-native-cli
$ yarn
```

- Run application
```bash
$ react-native run-ios
$ npx react-native run-ios
```
```bash
$ react-native run-android
$ npx react-native run-android
```

### Running single server
Expand Down